HBASE-29978 Remove redundant imports in regionserver.jsp file#7880
Merged
guluo2016 merged 1 commit intoapache:masterfrom Mar 10, 2026
Merged
HBASE-29978 Remove redundant imports in regionserver.jsp file#7880guluo2016 merged 1 commit intoapache:masterfrom
guluo2016 merged 1 commit intoapache:masterfrom
Conversation
liuxiaocs7
approved these changes
Mar 8, 2026
NihalJain
approved these changes
Mar 10, 2026
NihalJain
reviewed
Mar 10, 2026
| @@ -19,7 +19,6 @@ | |||
| --%> | |||
| <%@ page contentType="text/html;charset=UTF-8" | |||
| import="java.util.*" | |||
Contributor
There was a problem hiding this comment.
nit: not related. maybe get rid of .* imports
Member
Author
There was a problem hiding this comment.
I noticed this as well.
Actually, similar imports also exist in several other JSP files.
Maybe we can open a separate Jira issue to address this globally.
NihalJain
approved these changes
Mar 10, 2026
NihalJain
approved these changes
Mar 10, 2026
| @@ -19,7 +19,6 @@ | |||
| --%> | |||
| <%@ page contentType="text/html;charset=UTF-8" | |||
| import="java.util.*" | |||
Member
Author
|
Thanks @NihalJain @liuxiaocs7 @vaijosh for the review. |
guluo2016
added a commit
that referenced
this pull request
Mar 10, 2026
Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Liu Xiao <liuxiao2103@qq.com> Reviewed-by: Vaibhav Joshi <vjoshi@cloudera.com>
guluo2016
added a commit
that referenced
this pull request
Mar 10, 2026
Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Liu Xiao <liuxiao2103@qq.com> Reviewed-by: Vaibhav Joshi <vjoshi@cloudera.com>
guluo2016
added a commit
that referenced
this pull request
Mar 10, 2026
Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Liu Xiao <liuxiao2103@qq.com> Reviewed-by: Vaibhav Joshi <vjoshi@cloudera.com>
guluo2016
added a commit
that referenced
this pull request
Mar 10, 2026
Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Liu Xiao <liuxiao2103@qq.com> Reviewed-by: Vaibhav Joshi <vjoshi@cloudera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details see: HBASE-29978